TGooch44 commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r679081343
##########
File path: python/iceberg/api/schema.py
##########
@@ -49,6 +49,8 @@ def __init__(self, *argv):
self._lowercase_name_to_id = None
self._id_to_name = None
+ self.lazy_id_to_name()
Review comment:
Probably fine to keep this PR not too complex, but if we're no longer
lazy loading a lot of the code in this class can be a bit more succinct. I
know this currently matches what's in java, but I just find it a little strange
that the functions are named as lazy, but at least in the case of
lazy_id_to_name(), we're eagerly loading in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
