jun-he commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r680586889
##########
File path: python/iceberg/api/types/type_util.py
##########
@@ -117,15 +119,17 @@ def visit(arg, visitor): # noqa: ignore=C901
results = list()
for field in struct.fields:
visitor.field_ids.append(field.field_id)
- visitor.field_names.append(field.name)
+ visitor.field_names.appendleft(field.name)
Review comment:
yep, that will work as well. The current code uses a `list` and
`reverse()` and thus does not work. So we either use deque similar to Java or
we remove `reverse()`. I did the first option to match Java implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
