openinx commented on a change in pull request #2886:
URL: https://github.com/apache/iceberg/pull/2886#discussion_r679759141
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java
##########
@@ -258,4 +262,58 @@ public void testShuffleByPartitionWithSchema() throws
Exception {
Assert.assertEquals("There should be only 1 data file in partition
'ccc'", 1, partitionFiles("ccc"));
}
}
+
+ @Test
+ public void testTwoSinksInDisjointedDAG() throws Exception {
+ Map<String, String> props =
ImmutableMap.of(TableProperties.DEFAULT_FILE_FORMAT, format.name());
+
+ final String leftTablePath =
TEMPORARY_FOLDER.newFolder().getAbsolutePath().concat("/left");
Review comment:
Unit tests looks good to me. One minor thing: in apache iceberg
codebase, I have almost never seen a situation where local variables are
declared as final, @rdblue , Is this an implicit code style rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
