stevenzwu commented on a change in pull request #2886:
URL: https://github.com/apache/iceberg/pull/2886#discussion_r680088261
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -118,6 +117,7 @@ public static Builder forRowData(DataStream<RowData> input)
{
public static class Builder {
private DataStream<RowData> rowDataInput = null;
+ private SingleOutputStreamOperator<RowData> mappedRowDataInput = null;
Review comment:
Note that `mappedRowDataInput` is intentionally defined as
`SingleOutputStreamOperator` (not `DataStream `), because `DataStream` doesn't
expose `uid` and `name` method and hence we can't lazily add them to the `Map`
operator with `DataStream<RowData> rowDataInput`.
I agree that this is a little confusing and less than ideal. Another option
is to change Builder to a generic class like `Builder<T>`. but I don't like
that either and hence used the current implementation. I am very open to other
alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
