rdblue commented on a change in pull request #2926:
URL: https://github.com/apache/iceberg/pull/2926#discussion_r682764118
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -142,5 +154,10 @@ public long targetSplitSize() {
public Iterable<FileScanTask> split(long splitSize) {
return ImmutableList.of(this); // don't split
}
+
+ @VisibleForTesting
+ ManifestFile getManifest() {
Review comment:
I realize this is only for testing, but I would still suggest using a
method name that we don't have to change later if we want to use the method
elsewhere. That means removing `get` because `get` doesn't add anything.
Typically, `get` signals that the method name can be simpler (e.g., `manifest`
to return the manifest) or should have a more descriptive verb like `find`,
`fetch`, `create`, etc. that tell the caller more about what is happening. The
only time we use `get` is when the object needs to be a Java bean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
