szehon-ho commented on a change in pull request #2926:
URL: https://github.com/apache/iceberg/pull/2926#discussion_r684376653
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -109,11 +112,20 @@ public long targetSplitSize() {
Expression filter = ignoreResiduals ? Expressions.alwaysTrue() :
rowFilter;
ResidualEvaluator residuals = ResidualEvaluator.unpartitioned(filter);
+ // use an inclusive projection to remove the partition name prefix and
filter out any non-partition expressions
+ Expression partitionFilter = Projections
+ .inclusive(transformSpec(fileSchema, table().spec()), caseSensitive)
+ .project(rowFilter);
+
+ ManifestEvaluator manifestEval =
ManifestEvaluator.forPartitionFilter(partitionFilter, table().spec(),
+ caseSensitive);
Review comment:
You are right, done
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -142,5 +154,10 @@ public long targetSplitSize() {
public Iterable<FileScanTask> split(long splitSize) {
return ImmutableList.of(this); // don't split
}
+
+ @VisibleForTesting
+ ManifestFile getManifest() {
Review comment:
Ah got it , changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
