kbendick commented on a change in pull request #2943:
URL: https://github.com/apache/iceberg/pull/2943#discussion_r683801734
##########
File path: core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java
##########
@@ -1334,6 +1334,12 @@ public void testRemoveIdentifierFields() {
@Test
public void testSetIdentifierFieldsFails() {
+
+ AssertHelpers.assertThrows("Creating schema with optional identifier field
should fail",
+ IllegalArgumentException.class,
+ "Cannot add field data as an identifier field: not a required field",
+ () -> new Schema(SCHEMA.asStruct().fields(), ImmutableSet.of(1, 2)));
+
Review comment:
Is there a test for both double and float type already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
