rdblue commented on a change in pull request #2943:
URL: https://github.com/apache/iceberg/pull/2943#discussion_r685430105
##########
File path: api/src/main/java/org/apache/iceberg/Schema.java
##########
@@ -93,11 +93,39 @@ public Schema(int schemaId, List<NestedField> columns,
Map<String, Integer> alia
this.schemaId = schemaId;
this.struct = StructType.of(columns);
this.aliasToId = aliases != null ? ImmutableBiMap.copyOf(aliases) : null;
+
+ // validate IdentifierField
+ if (identifierFieldIds != null) {
+ Map<Integer, Integer> idToParent = TypeUtil.indexParents(this.struct);
Review comment:
Nit: accessing a field doesn't require the prefix `this.` Only assigning
a field should use `this.` so that it is clear that the assignment affects the
object's state and not just the local state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
