jun-he commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r686255475
##########
File path: python/iceberg/api/types/type_util.py
##########
@@ -121,6 +122,8 @@ def visit(arg, visitor): # noqa: ignore=C901
result = None
try:
result = visit(field.type, visitor)
+ except ValidationException as ve:
Review comment:
It might be better to always not swallow any errors. I can remove
`except` blocks and let the caller to handle the raised errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
