jun-he commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r689131513
##########
File path: python/iceberg/api/types/type_util.py
##########
@@ -121,6 +122,8 @@ def visit(arg, visitor): # noqa: ignore=C901
result = None
try:
result = visit(field.type, visitor)
+ except ValidationException as ve:
Review comment:
Ah, I probably know why. There are many code paths with
`NotImplementedError`. If not ignoring errors, multiple tests fail and the
build won't pass.
Also, looks like the visitor needs some rework to use `before` and `after`
methods (similar to Java). I feel we probably can leave it as it is and resolve
that after the rework is done and missing functions are implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
