aokolnychyi commented on a change in pull request #2945: URL: https://github.com/apache/iceberg/pull/2945#discussion_r687116592
########## File path: core/src/main/java/org/apache/iceberg/io/FileWriter.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.Closeable; +import java.io.IOException; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; + +/** + * A writer capable of writing files of a single type (i.e. data/delete) to one spec/partition. + * <p> + * As opposed to {@link FileAppender}, this interface should be implemented by classes that not only + * append records to files but actually produce {@link DataFile}s or {@link DeleteFile}s objects + * with Iceberg metadata. Implementations may wrap {@link FileAppender}s with extra information + * such as spec, partition, sort order ID needed to construct {@link DataFile}s or {@link DeleteFile}s. + */ +public interface FileWriter<T, R> extends Closeable { Review comment: @rdblue, I renamed this interface as `FileWriter`. My main motivation for that was to be more specific and follow the naming we use in `FileAppender`. I also added docs to describe the difference between the two. It may mean we should rename our recently added `WriterFactory` into `FileWriterFactory`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
