aokolnychyi commented on a change in pull request #2945: URL: https://github.com/apache/iceberg/pull/2945#discussion_r691588592
########## File path: core/src/main/java/org/apache/iceberg/io/PartitionAwareFileWriter.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.Closeable; +import java.io.IOException; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.StructLike; + +/** + * A writer capable of writing files of a single type (i.e. data/delete) to multiple specs and partitions. + * <p> + * As opposed to {@link FileWriter}, this interface should be implemented by writers that are not + * limited to writing to a single spec/partition. Implementations may under the hood use other + * {@link FileWriter}s for writing to a single spec/partition. + */ +public interface PartitionAwareFileWriter<T, R> extends Closeable { + + /** + * Writes a row to the provided spec/partition. + * + * @param row a data or delete record + * @param spec a partition spec + * @param partition a partition or null if the spec is unpartitioned + * @throws IOException in case of an error during the write process + */ + void write(T row, PartitionSpec spec, StructLike partition) throws IOException; + + /** + * Returns a result that contains information about written {@link DataFile}s or {@link DeleteFile}s. + * The result is valid only after the writer is closed. Review comment: I mostly followed the pattern we use in other places such as `DataWriter` and `EqualityDeleteWriter`. I guess we have a very similar design for our appenders too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
