aokolnychyi commented on a change in pull request #2984:
URL: https://github.com/apache/iceberg/pull/2984#discussion_r689834079
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java
##########
@@ -72,12 +62,7 @@ public BaseStatistics getStatistics(BaseStatistics
cachedStatistics) {
@Override
public FlinkInputSplit[] createInputSplits(int minNumSplits) throws
IOException {
- // Called in Job manager, so it is OK to load table from catalog.
- tableLoader.open();
Review comment:
@stevenzwu @openinx, this is something we talked a little bit about in
#2978.
After a closer look, this would actually change the behavior. As of now, the
table is loaded two times: in `FlinkSource` and in `FlinkInputFormat`. After
this change, we only load it in `FlinkSource` and then pass a read-only
serializable copy to `FlinkInputFormat`.
What is the lifecycle of `FlinkInputFormat`? Is it alright to pass a
read-only table to it that won't pick up any new snapshots or table properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
