aokolnychyi commented on a change in pull request #2984: URL: https://github.com/apache/iceberg/pull/2984#discussion_r689836312
########## File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java ########## @@ -72,12 +62,7 @@ public BaseStatistics getStatistics(BaseStatistics cachedStatistics) { @Override public FlinkInputSplit[] createInputSplits(int minNumSplits) throws IOException { - // Called in Job manager, so it is OK to load table from catalog. - tableLoader.open(); Review comment: As I stated above, I've put Flink and MR related changes into this PR just temporarily. Instead of passing `Table`, I can add one more parameter and pass a partition type alongside other existing parameters. Using `Table` seems cleaner but not a blocker for my current work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org