stevenzwu commented on a change in pull request #3001:
URL: https://github.com/apache/iceberg/pull/3001#discussion_r692681309
##########
File path: build.gradle
##########
@@ -320,6 +320,8 @@ project(':iceberg-flink') {
compile project(':iceberg-parquet')
compile project(':iceberg-hive-metastore')
+ // for dropwizard histogram metrics implementation
+ compileOnly "org.apache.flink:flink-metrics-dropwizard"
Review comment:
I was wondering if this should be `compile` dep.
flink-metrics-dropwizard is not part of flink-dist. User would need to bring it
in. I stayed with `compileOnly` as the same argument applied to other
`flink-table-*` deps
```
compileOnly "org.apache.flink:flink-table-api-java-bridge_2.12"
compileOnly "org.apache.flink:flink-table-planner-blink_2.12"
compileOnly "org.apache.flink:flink-table-planner_2.12"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
