szehon-ho commented on a change in pull request #3001:
URL: https://github.com/apache/iceberg/pull/3001#discussion_r695329688
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -249,6 +251,19 @@ public Builder uidPrefix(String newPrefix) {
return this;
}
+ /**
+ * Set the {@link SlidingWindowReservoir} size (number of measurements
stored)
+ * for the two histogram metrics of data files and delete file size
distribution.
+ *
+ * @param newReservoirSize
+ * default is 128, which only add a small memory overhead of 1 KB (128 x
8B) per histogram. For large
Review comment:
Yep, thanks, I was thinking more for complete sentence
```The default reservoir size is 128, which adds a small memory...```
or if its part of the param comment
```@param newReservoirSize defaults to 128, which adds a small memory
overhead of 1kb```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
