stevenzwu commented on a change in pull request #2898:
URL: https://github.com/apache/iceberg/pull/2898#discussion_r693623631
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java
##########
@@ -148,10 +159,6 @@ private void testChangeLogs(List<String>
equalityFieldColumns,
List<List<Record>> expectedRecordsPerCheckpoint)
throws Exception {
DataStream<Row> dataStream = env.addSource(new
BoundedTestSource<>(elementsPerCheckpoint), ROW_TYPE_INFO);
- // Shuffle by the equality key, so that different operations of the same
key could be wrote in order when
Review comment:
maybe this unit test demonstrates the original intention that FlinkSink
assumes certainly ordering of input stream and it is not the responsibility of
the FlinkSink to correct any ordering problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
