stevenzwu commented on a change in pull request #2898:
URL: https://github.com/apache/iceberg/pull/2898#discussion_r693619492
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -140,13 +141,14 @@ private Builder forRowData(DataStream<RowData>
newRowDataInput) {
MapFunction<T, RowData> mapper,
TypeInformation<RowData>
outputType) {
this.inputCreator = newUidPrefix -> {
+ // Input stream order is crucial for some situation(e.g. in cdc case),
So we need to set the map opr
+ // parallelism as it's input to keep map opr chain to input, and
ensure input stream will not be rebalanced.
Review comment:
I agree with this change. Since map operator is part of the Flink sink,
it is ok to set the parallelism to whatever it is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
