jackye1995 commented on pull request #2961: URL: https://github.com/apache/iceberg/pull/2961#issuecomment-903950996
@rdblue thanks for the suggestion! One thing around the immutable nature of snapshot I thought about is that, in encryption we still have the need to add the ability to rotate key. The encryption metadata or its location will likely be a part of snapshot which will change after rotation. This goes to the point I was discussing above, I think snapshot content is of course immutable, but I am not sure if we can continue to keep properties describing the snapshot immutable. For lifecycle, yes I was thinking about adding this as a part of a Tag object, but if we go with placing it in table metadata it will be the way you described. For JSON object instead of map, yes If it is in table metadata it will be an object similar to how we implement other fields. I was just trying to simplify the idea. For the branch example you gave, could you elaborate more about its semantics and usage? I don't see how it would be used without having a complete DAG of commits, and how its relationship would be with the Nessie project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
