stevenzwu commented on a change in pull request #2961:
URL: https://github.com/apache/iceberg/pull/2961#discussion_r697807553



##########
File path: api/src/main/java/org/apache/iceberg/Snapshot.java
##########
@@ -135,4 +135,12 @@
   default Integer schemaId() {
     return null;
   }
+
+  /**
+   * Return the tags associated with the snapshot, or null if no tags are 
associated with the snapshot.
+   * @return tags associated with the snapshot, or null if no tags are 
associated with the snapshot.
+   */
+  default List<String> tags() {

Review comment:
       what about `Set<String>` as return type?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to