nastra commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r697209647
##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,24 +1,5 @@
-#
Review comment:
I thought it's only the checkstyle rule that makes sure there's a
license header on **java/ts** files
(https://github.com/apache/iceberg/blob/970e8aac60081c7d286ab0f7e12e428b3309dd34/.baseline/checkstyle/checkstyle.xml#L18-L21).
Based on [this
comment](https://github.com/gradle/gradle/issues/2852#issuecomment-347204733) I
would probably leave out the license header from the properties file, since
it's _just_ a configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
