nastra commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r708866670
##########
File path: build.gradle
##########
@@ -498,24 +543,26 @@ project(':iceberg-hive-metastore') {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
}
- testCompile project(path: ':iceberg-api', configuration: 'testArtifacts')
+ testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
}
}
project(':iceberg-mr') {
configurations {
- testCompile {
+ testImplementation {
exclude group: 'org.apache.parquet', module: 'parquet-hadoop-bundle'
}
}
dependencies {
- compile project(':iceberg-api')
- compile project(':iceberg-core')
- compile project(':iceberg-data')
- compile project(':iceberg-hive-metastore')
- compile project(':iceberg-orc')
- compile project(':iceberg-parquet')
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+ implementation project(':iceberg-data')
Review comment:
good point, updated this and `iceberg-spark`/`iceberg-flink` to an `api`
dependency, since those were also using iceberg-data class in their API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
