kbendick commented on a change in pull request #2969: URL: https://github.com/apache/iceberg/pull/2969#discussion_r697732533
########## File path: flink/src/main/java/org/apache/iceberg/flink/util/FlinkScalaUtil.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.util; + +import org.apache.flink.streaming.api.scala.DataStream; + +public class FlinkScalaUtil { + private FlinkScalaUtil() { + } + + /** + * Converts an [[org.apache.flink.streaming.api.datastream.DataStream]] to a + * [[org.apache.flink.streaming.api.scala.DataStream]]. + */ + public static <T> DataStream<T> asScalaStream( + org.apache.flink.streaming.api.datastream.DataStream<T> javaDataStream) { + return new DataStream<>(javaDataStream); + } Review comment: Is it possible to reduce the code changes for the existing code, and then just place the conversions as needed in here? ########## File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java ########## @@ -117,7 +109,7 @@ public static Builder forRowData(DataStream<RowData> input) { return new Builder().forRowData(input); } - public static class Builder { + public static class Builder<T extends Builder<T>> { Review comment: I'm not quite sure I understand why this templating addition is needed. Could you help clarify that for me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
