stevenzwu commented on a change in pull request #3061:
URL: https://github.com/apache/iceberg/pull/3061#discussion_r701568236
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -249,7 +249,7 @@ public Builder uidPrefix(String newPrefix) {
return this;
}
- public DataStreamSink<RowData> build() {
+ public DataStreamSink<Void> build() {
Review comment:
> it's still necessary to return a DataStreamSink<Void> in case of
people want to set their own name, uid, ChainingStrategy
I am not sure if we want to enable users to do that. The dummy sink is part
of the Flink Iceberg sink DAG: map (optional) -> writer -> committer -> dummy
sink. We don't allow users to change the properties (like name, uid, chaining
strategy, parallelism, slot sharing group) for other operators. why do we want
to allow the change only for the dummy sink operator.
But I am not against returning `DataStreamSink<Void>`, as in theory it is
natural. I just have some doubt on the practical values of exposing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
