openinx commented on a change in pull request #3061:
URL: https://github.com/apache/iceberg/pull/3061#discussion_r702842192
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -249,7 +249,7 @@ public Builder uidPrefix(String newPrefix) {
return this;
}
- public DataStreamSink<RowData> build() {
+ public DataStreamSink<Void> build() {
Review comment:
Hi @stevenzwu , we need to return a `DataStreamSink<Void>` because in
the
[IcebergTableSink](https://github.com/apache/iceberg/blob/a0d6cdf8a76e29d07ce0d5889b7ee9a2335bde1f/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java#L62),
we will need to return a `DataStreamSink` to implement the
[DataStreamSinkProvider](https://github.com/apache/flink/blob/db5af67aee7fb449a9db8930213eec7dc925e58c/flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
