stevenzwu commented on a change in pull request #2905:
URL: https://github.com/apache/iceberg/pull/2905#discussion_r702009925
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/DataIterator.java
##########
@@ -21,64 +21,38 @@
import java.io.IOException;
import java.io.UncheckedIOException;
-import java.nio.ByteBuffer;
import java.util.Iterator;
-import java.util.Map;
-import java.util.stream.Stream;
+import org.apache.flink.annotation.Internal;
import org.apache.iceberg.CombinedScanTask;
import org.apache.iceberg.FileScanTask;
-import org.apache.iceberg.encryption.EncryptedFiles;
-import org.apache.iceberg.encryption.EncryptedInputFile;
import org.apache.iceberg.encryption.EncryptionManager;
+import org.apache.iceberg.encryption.InputFilesDecryptor;
import org.apache.iceberg.io.CloseableIterator;
import org.apache.iceberg.io.FileIO;
-import org.apache.iceberg.io.InputFile;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
/**
- * Base class of Flink iterators.
+ * Flink data iterator that reads {@link CombinedScanTask} into a {@link
CloseableIterator}
*
- * @param <T> is the Java class returned by this iterator whose objects
contain one or more rows.
+ * @param <T> is the output data type returned by this iterator.
*/
-abstract class DataIterator<T> implements CloseableIterator<T> {
+@Internal
Review comment:
we can add an `@Internal` annotation to the
`org.apache.iceberg.annotation` package in `iceberg-api`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
