openinx commented on a change in pull request #2905:
URL: https://github.com/apache/iceberg/pull/2905#discussion_r701734664
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java
##########
@@ -42,21 +42,22 @@
private static final long serialVersionUID = 1L;
private final TableLoader tableLoader;
- private final Schema tableSchema;
private final FileIO io;
private final EncryptionManager encryption;
private final ScanContext context;
+ private final RowDataFileReader rowDataReader;
- private transient RowDataIterator iterator;
+ private transient DataIterator<RowData> iterator;
private transient long currentReadCount = 0L;
FlinkInputFormat(TableLoader tableLoader, Schema tableSchema, FileIO io,
EncryptionManager encryption,
ScanContext context) {
this.tableLoader = tableLoader;
- this.tableSchema = tableSchema;
this.io = io;
this.encryption = encryption;
this.context = context;
+ this.rowDataReader = new RowDataFileReader(tableSchema,
Review comment:
You mean there will be other data type applied to the generic
`DataIterator` ( For example for flip-24 ) ? There seems no other
`FileScanTaskReader` implementation except the RowDataFileScanTaskReader. I
think we may don't want to the generic type for the `DataIterator`, then we
also don't need the extra `FileScanTaskReader` (we could just rename the
RowDataFileScanTaskReader to FileScanTaskReader directly), and finally we
construct the FileScanTaskReader inside the DataIterator. How do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
