wypoon commented on pull request #1508: URL: https://github.com/apache/iceberg/pull/1508#issuecomment-914861620
@rdblue, I have rebased on master and updated the PR with most of your suggestions. The only change you suggested that I did not adopt concerns having both `snapshotId` and `asOfTimestamp` in `SnapshotAwareIdentifier`. I explained my reason above. I hope that this is ready to merge now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
