kbendick commented on a change in pull request #3089:
URL: https://github.com/apache/iceberg/pull/3089#discussion_r704943607
##########
File path: core/src/main/java/org/apache/iceberg/MetadataTableUtils.java
##########
@@ -68,4 +82,8 @@ public static Table
createMetadataTableInstance(TableOperations ops,
String metadataTableName = BaseMetastoreCatalog.fullTableName(catalogName,
metadataTableIdentifier);
return createMetadataTableInstance(ops, baseTableName, metadataTableName,
type);
}
+
+ private static String metadataTableName(String tableName, MetadataTableType
type) {
+ return tableName + (tableName.contains("/") ? "#" : ".") + type;
Review comment:
Question: I have not seen any implementations that do this, but I
believe that this character can be set. Technically, I think it would be
possible for the whole name to be set by somebody presently, though I doubt
anybody is doing that.
Should we consider either enforcing these characters or allowing for the
possibility of extra tables and metadata tables to table types (e.g. maybe Glue
table type for some spelling reason, etc)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
