rdblue commented on a change in pull request #3069:
URL: https://github.com/apache/iceberg/pull/3069#discussion_r705784207
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -129,6 +119,7 @@ protected void validate(TableMetadata base) {
if (conflictDetectionFilter != null && base.currentSnapshot() != null) {
validateAddedDataFiles(base, startingSnapshotId,
conflictDetectionFilter, caseSensitive);
+ validateAddedDeleteFiles(base, startingSnapshotId,
conflictDetectionFilter, caseSensitive);
Review comment:
Yeah, I think it would be good to keep the two separate. That would
allow fine-grained control of validation and avoid the need to rename the
validation config method -- just add a second one. Would we need to validate
there are no conflicting deletes in all cases? Seems like we wouldn't
necessarily need to if using snapshot isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
