[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3069: Core: Validate conflicting delete files in RowDelta and OverwriteFiles

[GitBox]

aokolnychyi commented on a change in pull request #3069:
URL: https://github.com/apache/iceberg/pull/3069#discussion_r706545508



##########
File path: core/src/main/java/org/apache/iceberg/BaseRowDelta.java
##########
@@ -81,23 +82,32 @@ public RowDelta validateDataFilesExist(Iterable<? extends 
CharSequence> referenc
   }
 
   @Override
-  public RowDelta validateNoConflictingAppends(Expression 
newConflictDetectionFilter) {
+  public RowDelta validateNoConflictingOperations(Expression 
newConflictDetectionFilter) {
     Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict 
detection filter cannot be null");
     this.conflictDetectionFilter = newConflictDetectionFilter;
     return this;
   }
 
+  @Override
+  public RowDelta validateNoConflictingDeleteFiles() {
+    this.validateNoConflictingDeleteFiles = true;
+    return this;
+  }
+
   @Override
   protected void validate(TableMetadata base) {
     if (base.currentSnapshot() != null) {
       if (!referencedDataFiles.isEmpty()) {
         validateDataFilesExist(base, startingSnapshotId, referencedDataFiles, 
!validateDeletes);
       }
 
-      // TODO: does this need to check new delete files?
       if (conflictDetectionFilter != null) {
         validateAddedDataFiles(base, startingSnapshotId, 
conflictDetectionFilter, caseSensitive);
       }
+
+      if (conflictDetectionFilter != null && validateNoConflictingDeleteFiles) 
{
+        validateAddedDeleteFiles(base, startingSnapshotId, 
conflictDetectionFilter, caseSensitive);

Review comment:
       Well, I think we could approach it differently. Let me update and then 
we can discuss more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org