rdblue commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r705800767
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -141,4 +133,18 @@ private static String stripTrailingSlash(String path) {
}
return result;
}
+
+ public static String dataLocation(Map<String, String> properties, String
tableLocation) {
+ String dataLocation = properties.get(TableProperties.WRITE_DATA_LOCATION);
+ if (dataLocation == null) {
+ dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH);
Review comment:
This is only correct if the table is using object storage. I think you
need to update this logic to select whether to return OBJECT_STORE_PATH or
WRITE_FOLDER_STORAGE_LOCATION depending on the location provider selected. Both
should fall back to the table location. And the new property should take
precedence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
