flyrain commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r706373556



##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -141,4 +140,20 @@ private static String stripTrailingSlash(String path) {
     }
     return result;
   }
+
+  private static String dataLocation(Map<String, String> properties, String 
tableLocation, String deprecatedProperty) {
+    String dataLocation = properties.get(TableProperties.WRITE_DATA_LOCATION);
+    if (dataLocation == null) {
+      dataLocation = properties.get(deprecatedProperty);

Review comment:
       We don't have to check if deprecatedProperty is null, the map can take a 
null.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to