itachi-sharingan commented on a change in pull request #3126:
URL: https://github.com/apache/iceberg/pull/3126#discussion_r711222173



##########
File path: 
spark3/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java
##########
@@ -242,6 +242,9 @@ public void renameTable(Identifier from, Identifier to) 
throws NoSuchTableExcept
 
   @Override
   public final void initialize(String name, CaseInsensitiveStringMap options) {
+    if (options.containsKey("type") && 
options.get("type").equalsIgnoreCase("hive") && options.containsKey("uri")) {
+      throw new UnsupportedOperationException("Passing hive catalog uri 
through spark.sql.catalog.<catalog_name>.uri is not allowed̉.");

Review comment:
       Sure, have added a test for this scenario and changes the exception 
message. Please check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to