itachi-sharingan commented on a change in pull request #3126:
URL: https://github.com/apache/iceberg/pull/3126#discussion_r711519803
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java
##########
@@ -242,6 +242,13 @@ public void renameTable(Identifier from, Identifier to)
throws NoSuchTableExcept
@Override
public final void initialize(String name, CaseInsensitiveStringMap options) {
+ if (options.containsKey("type") &&
options.get("type").equalsIgnoreCase("hive") && options.containsKey("uri")) {
+ throw new UnsupportedOperationException("Cannot set an alternative uri
when" +
+ " using the SparkSessionCatalog, " +
+ "make an alternative SparkCatalog if the " +
+ "Spark Session catalog and Iceberg " +
+ "catalog should contact different metastores.");
+ }
Review comment:
Agreed, this will make it backward compatible to some extent but
allowing this will make the config set up more prone to error as when someone
is changing the thrift server uri they would now have to do it at two places.
Its more of a tradeoff between the two situations - backward compatible vs one
config one place. @RussellSpitzer @rdblue what are your opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
