rdblue commented on a change in pull request #3135:
URL: https://github.com/apache/iceberg/pull/3135#discussion_r712314926
##########
File path: data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
##########
@@ -51,18 +54,32 @@
Types.NestedField.required(2, "data", Types.StringType.get())
);
+ public static final Schema DATE_SCHEMA = new Schema(
+ Types.NestedField.required(1, "dt", Types.DateType.get()),
+ Types.NestedField.required(2, "data", Types.StringType.get()),
+ Types.NestedField.required(3, "id", Types.IntegerType.get())
+ );
+
// Partition spec used to create tables
public static final PartitionSpec SPEC = PartitionSpec.builderFor(SCHEMA)
.bucket("data", 16)
.build();
+ public static final PartitionSpec DATE_SPEC =
PartitionSpec.builderFor(DATE_SCHEMA)
+ .day("dt")
+ .build();
+
@Rule
public TemporaryFolder temp = new TemporaryFolder();
- private String tableName = null;
+ protected String tableName = null;
+ protected String tableName2 = null;
Review comment:
Please use more descriptive names that `tableName2`. Maybe
`dateTableName`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
