rdblue commented on a change in pull request #3135:
URL: https://github.com/apache/iceberg/pull/3135#discussion_r712316560
##########
File path: data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
##########
@@ -330,6 +407,15 @@ private StructLikeSet rowSetWithoutIds(int... idsToRemove)
{
return set;
}
+ protected StructLikeSet rowSetWithoutIds2(int... idsToRemove) {
Review comment:
Instead of duplicating logic, please update the existing method so that
the table is passed in. If you want to minimize changes, just add an override
with the old method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
