nastra commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r713107495
##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -202,6 +202,16 @@ public static boolean dropTable(Configuration conf,
Properties props) {
*/
public static boolean hiveCatalog(Configuration conf, Properties props) {
String catalogName = props.getProperty(InputFormatConfig.CATALOG_NAME);
+ return hiveCatalog(conf, catalogName);
+ }
+
+ /**
+ * Returns true if HiveCatalog is used
+ * @param conf a Hadoop conf
+ * @param catalogName name of the catalog
+ * @return true if the Catalog is HiveCatalog
+ */
+ public static boolean hiveCatalog(Configuration conf, String catalogName) {
Review comment:
is this change still needed then with the new approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
