omarsmak commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r713158097
##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -270,22 +287,41 @@ public static boolean hiveCatalog(Configuration conf,
Properties props) {
*/
private static String getCatalogType(Configuration conf, String catalogName)
{
if (catalogName != null) {
- String catalogType = conf.get(InputFormatConfig.catalogPropertyConfigKey(
- catalogName, CatalogUtil.ICEBERG_CATALOG_TYPE));
Review comment:
It is not needed but IMHO makes the code in `getCatalogType` easier to
follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
