zhengzengprc commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r713469514
##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -65,12 +65,18 @@ public static boolean ancestorOf(Table table, long
snapshotId, long ancestorSnap
}
/**
- * Traverses the history of the table's current snapshot and finds the
oldest Snapshot.
- * @return null if there is no current snapshot in the table, else the
oldest Snapshot.
+ * Traverses the history of the table's current snapshot
+ * and finds the oldest Snapshot after or equal to the timestamp in
milliseconds.
+ * @return null if there is no current snapshot in the table,
+ * else the oldest Snapshot after or equal to the timestamp in milliseconds.
*/
- public static Snapshot oldestSnapshot(Table table) {
+ public static Snapshot oldestSnapshot(Table table, long timestampMillis) {
Review comment:
I agree oldestAncestorAfter is a better name.
But I don't think NPE will be happen, the method indeed will only return a
snapshot if its parent is still known and older than the timestamp.
For the “if the parent is no longer tracked” I am not sure when it will
happen, based on my understanding, we does have safety check:
`while (current.parentId() != null &&
table.snapshot(current.parentId()).timestampMillis() >= timestampMillis)`
I think this logic will handle the parent is not existed case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
