zhengzengprc commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r713509070
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java
##########
@@ -106,7 +107,9 @@
this.splitOpenFileCost = Spark3Util.propertyAsLong(
options, SparkReadOptions.FILE_OPEN_COST, tableSplitOpenFileCost);
- InitialOffsetStore initialOffsetStore = new InitialOffsetStore(table,
checkpointLocation);
+ this.fromTimestamp = Spark3Util.propertyAsLong(options,
SparkReadOptions.STREAM_FROM_TIMESTAMP, -1L);
Review comment:
We expect the behavior that if the fromTimestamp is not set, we wanna
start from the timestamp 0. If we wanna set the fromTimestamp to null, we will
reset it to -1 or 0 later. I think it is fine to use -1 as default value here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
