ayush-san commented on a change in pull request #3103:
URL: https://github.com/apache/iceberg/pull/3103#discussion_r713615385
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -283,6 +287,7 @@ private void commitDeltaTxn(NavigableMap<Long, WriteResult>
pendingResults, Stri
// merged one will lead to the incorrect delete semantic.
WriteResult result = e.getValue();
RowDelta rowDelta = table.newRowDelta()
+ .validateFromSnapshot(lastCommittedSnapshotId)
Review comment:
What will be the value of `lastCommittedSnapshotId` if I restore the job
from a savepoint?
Shouldn't we do something similar for it as we do for
`maxCommittedCheckpointId` but here many things to consider as if we run expire
snapshot maintenance procedure before restoring the job from the
savepoint(https://github.com/apache/iceberg/issues/2482#issuecomment-897017924)
```
this.lastCommittedSnapshotId = getLastCommittedSnapshotId(table);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
