Reo-LEI commented on a change in pull request #3103:
URL: https://github.com/apache/iceberg/pull/3103#discussion_r718183168
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -283,6 +287,7 @@ private void commitDeltaTxn(NavigableMap<Long, WriteResult>
pendingResults, Stri
// merged one will lead to the incorrect delete semantic.
WriteResult result = e.getValue();
RowDelta rowDelta = table.newRowDelta()
+ .validateFromSnapshot(lastCommittedSnapshotId)
Review comment:
@ayush-san I'm very sorry, this is my mistake, I want to link to
https://github.com/apache/iceberg/issues/3102#issuecomment-919073751, but not
#2867 .
And I think this PR will not solving
https://github.com/apache/iceberg/issues/2482. if the validation error not
fixed, this PR will encounter the same problem. I think we should follow
https://github.com/apache/iceberg/pull/2603#issuecomment-861831900 this to
check the exists files to fix the validation error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
