jackye1995 commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r713625572
##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -212,6 +212,14 @@ public static boolean hiveCatalog(Configuration conf,
Properties props) {
return Optional.empty();
} else {
String name = catalogName == null ? ICEBERG_DEFAULT_CATALOG_NAME :
catalogName;
+
+ String catalogImpl = conf.get(InputFormatConfig.catalogPropertyConfigKey(
Review comment:
I think instead of doing the check here it's simpler to do the check in
`addCatalogPropertiesIfMissing` before we set
`CatalogUtil.ICEBERG_CATALOG_TYPE` to something. By doing that, you do not need
to get the actual impl like this and you can just check
`catalogProperties.containsKey(CatalogProperties.CATALOG_IMPL)`. This also
allows compatibility with legacy catalog impl Hadoop config key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
