aokolnychyi commented on a change in pull request #3171:
URL: https://github.com/apache/iceberg/pull/3171#discussion_r715968765
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
##########
@@ -538,68 +543,127 @@ protected WriterFactory(Broadcast<Table> tableBroadcast,
FileFormat format, long
@Override
public DataWriter<InternalRow> createWriter(int partitionId, long taskId,
long epochId) {
Table table = tableBroadcast.value();
-
- OutputFileFactory fileFactory = OutputFileFactory.builderFor(table,
partitionId, taskId).format(format).build();
- SparkAppenderFactory appenderFactory =
SparkAppenderFactory.builderFor(table, writeSchema, dsSchema).build();
-
PartitionSpec spec = table.spec();
FileIO io = table.io();
+ OutputFileFactory fileFactory = OutputFileFactory.builderFor(table,
partitionId, taskId)
+ .format(format)
+ .build();
+ SparkFileWriterFactory writerFactory =
SparkFileWriterFactory.builderFor(table)
Review comment:
I replicated the old behavior with `SparkAppenderFactory` but I can
check whether it is something we can create per task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
