rdblue commented on a change in pull request #2984:
URL: https://github.com/apache/iceberg/pull/2984#discussion_r716256726
##########
File path:
spark3/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java
##########
@@ -31,7 +30,14 @@
@Override
public Table loadTable(Identifier ident) throws NoSuchTableException {
- TestTables.TestTable table =
TestTables.load(Spark3Util.identifierToTableIdentifier(ident).toString());
- return new SparkTable(table, false);
+ String[] parts = ident.name().split("\\$", 2);
+ if (parts.length == 2) {
+ TestTables.TestTable table = TestTables.load(parts[0]);
+ String[] metadataColumns = parts[1].split(",");
+ return new SparkTestTable(table, metadataColumns, false);
Review comment:
This is just a different way to pass metadata columns in? Is there a
better way to test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
