rdblue commented on a change in pull request #2984: URL: https://github.com/apache/iceberg/pull/2984#discussion_r716266476
########## File path: spark/src/main/java/org/apache/iceberg/spark/source/BaseDataReader.java ########## @@ -132,6 +142,15 @@ protected InputFile getInputFile(String location) { return inputFiles.get(location); } + protected Map<Integer, ?> constantsMap(FileScanTask task, Schema readSchema) { + if (readSchema.findField(MetadataColumns.PARTITION_COLUMN_ID) != null) { + StructType partitionType = Partitioning.partitionType(table); + return PartitionUtil.constantsMap(task, partitionType, BaseDataReader::convertConstant); Review comment: Can we leave unknown transforms out of the partition type instead? We can just ignore them if they're unknown? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org