liubo1022126 removed a comment on pull request #3130: URL: https://github.com/apache/iceberg/pull/3130#issuecomment-927585644
> @liubo1022126 I would add option 3: set the watermark as table property (not snapshot summary). This is what we did at Netflix before. > > * pro: Storing watermark in table properties make it easier for consumer > * con: It needs `Table#newTransaction` to commit append and table properties update together. Transaction change might require bigger refactor in the IcebergFilesCommitter. @stevenzwu ok, I'm agree with it. what about mark it in both the snapshot of the append operation and the table properties. In append snapshot, we can get the ability of trend analysis. Mark the latest watermark in the table properties, user can use it very conveniently. `private Long watermark = WATERMARK_VALUE_DEFAULT;` watermark is a timestamp, so type is long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
