stevenzwu commented on a change in pull request #3130:
URL: https://github.com/apache/iceberg/pull/3130#discussion_r719920777
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -228,4 +228,10 @@ private TableProperties() {
public static final String MERGE_CARDINALITY_CHECK_ENABLED =
"write.merge.cardinality-check.enabled";
public static final boolean MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT = true;
+
+ public static final String WATERMARK_FIELD_NAME = "write.watermark.field";
+ public static final String WATERMARK_FIELD_NAME_DEFAULT = "";
+
+ public static final String WATERMARK_VALUE = "write.watermark";
Review comment:
In the past, we have 3 Flink streaming jobs (1 for each AWS region)
writing to the same table. We need to write to 3 different watermark table
properties (1 for each region). Watermark consumer then use the min value to
determine the overall table watermark.
A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A
default impl could be a single property name. not sure if there is a simpler
way to achieve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
