rdblue commented on a change in pull request #2680:
URL: https://github.com/apache/iceberg/pull/2680#discussion_r717682742
##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
##########
@@ -238,6 +238,8 @@ public void write(Object s, Encoder encoder) throws
IOException {
encoder.writeString((Utf8) s);
} else if (s instanceof String) {
encoder.writeString(new Utf8((String) s));
+ } else if (s instanceof CharSequence) {
+ encoder.writeString((CharSequence) s);
Review comment:
Why is this needed? We generally want to avoid writing `CharSequence`
directly because it will require conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
